Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for arduino R4 #181

Closed

Conversation

VIPQualityPost
Copy link

Add PIO envs and change untested hardware build error to warning.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a define guard for the new R4 platform.

@dl1com
Copy link
Contributor

dl1com commented Jan 22, 2024

As discussed in the last meeting, as we face the need for supporting multiple hardware platforms (UNO, UNO R4, AYAB-ESP32), we'll have to adjust the firmware CI accordingly so it generates and uploads multiple binaries.
So this should be added to this PR already. (building both UNO and R4 binaries).

Plus, the Desktop software shall be capable of handling these different binaries (downloading the binary releases using the manifest file, showing them in the firmware flash UI, be able to flash them to the target (esp32 flash tool required to be shipped)) (I added an issue for this here: AllYarnsAreBeautiful/ayab-desktop#612)

@dl1com
Copy link
Contributor

dl1com commented Feb 26, 2024

I just had another look at this PR... it seems the base branch is odd, as git tries to rebase 48 commits (which is about the distance to the current state of the main branch.

Where do we want the R4 change to show up? Is it still relevant for 0.95 or is it sufficient to have it in 1.0? (or vice versa?)

@VIPQualityPost
Copy link
Author

I can fix it so that it's just coming off main.. but this should not be pulled into 1.0 I think, we can roll in support for this alongside ESP32 in a post-v1.0 feature release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants